Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Folderwatcher] [WIP] Azure blob storage containers monitoring support #14926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goopilot
Copy link
Contributor

@goopilot goopilot commented May 2, 2023

Signed-off-by: Alexandr Salamatov goopilot@gmail.com

Added support for monitoring of Azure blob storage containers

DocumentBuilder docBuilder = docBuilderFactory.newDocumentBuilder();
// This returns extra character before <xml. Need to find out why
String sResponse = contentResponse.getContentAsString();
InputSource is = new InputSource(new StringReader(sResponse.substring(sResponse.indexOf("<"))));
Copy link
Contributor Author

@goopilot goopilot May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doing this, but I don't like it.
The reason why I'm doing this that Azure in the HTTP response has some additional character before <?xml statement. So the DOM parser fails.

Wireshark also shows it:
2023-05-02 16 24 29

Did anybody experience that and if yes, what is the best solution?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wborn did you experience similar issue with Azure?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, maybe it's a BOM?

https://en.m.wikipedia.org/wiki/Byte_order_mark

@lolodomo
Copy link
Contributor

I added the tag "work in progress" as "WIP" is still in the PR title.
Let us know when this is no more "work in progress".

@lolodomo lolodomo added work in progress A PR that is not yet ready to be merged enhancement An enhancement or new feature for an existing add-on labels May 25, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Sep 29, 2024

Gentle ping @goopilot after 1.5 years without visible progress i wonder if you need any support and if we can bring this PR to the finish line.

@goopilot
Copy link
Contributor Author

Gentle ping @goopilot after 1.5 years without visible progress i wonder if you need any support and if we can bring this PR to the finish line.

Thanks for reminding me, I'll work on it this month

@lsiepel lsiepel added the awaiting feedback Awaiting feedback from the pull request author label Oct 26, 2024
@goopilot goopilot force-pushed the azure branch 2 times, most recently from d1615d5 to 0f5d9d5 Compare January 10, 2025 16:42
Signed-off-by: Alexandr Salamatov <goopilot@gmail.com>
@goopilot
Copy link
Contributor Author

@lsiepel could you have a look at it? I'm done with it.

@lsiepel lsiepel removed the awaiting feedback Awaiting feedback from the pull request author label Jan 10, 2025
@lsiepel
Copy link
Contributor

lsiepel commented Jan 10, 2025

@lsiepel could you have a look at it? I'm done with it.

Currently away, will try to look at it in the next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants